Gracefully shutdown HTTP, gRPC, and Prom servers #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This catches sigint and sigterm and calls each server's shutdown method, blocking until shutdown completes. This is only added for non-Duplex, we'll need to add a shutdown method for Duplex servers. Signed-off-by: Hayden Blauzvern <[email protected]>
|
Tested with I tried to get this working for Duplex by calling |
Codecov Report
@@ Coverage Diff @@
## main #1342 +/- ##
==========================================
- Coverage 58.49% 57.56% -0.93%
==========================================
Files 50 50
Lines 3053 3111 +58
==========================================
+ Hits 1786 1791 +5
- Misses 1110 1161 +51
- Partials 157 159 +2
|
Signed-off-by: Hayden Blauzvern <[email protected]>
bobcallaway
reviewed
Sep 1, 2023
Signed-off-by: Hayden Blauzvern <[email protected]>
|
@bobcallaway Fixed comments, also made the unix domain socket configurable so that you can start up two fulcios on the same machine |
bobcallaway
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This catches sigint and sigterm and calls each server's shutdown method, blocking until shutdown completes.
This is only added for non-Duplex, we'll need to add a shutdown method for Duplex servers.
Fixes #1341
Summary
Release Note
Documentation